Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Modernize cmake #17

Merged
merged 10 commits into from
May 2, 2024
Merged

Conversation

FrogTheFrog
Copy link
Collaborator

Description

Modernize CMake by using recommended functions and patterns

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@FrogTheFrog FrogTheFrog marked this pull request as draft April 28, 2024 10:03
Copy link
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have cmake experience outside of Sunshine, but the approach seems good overall. Might be good to eventually port what we end up with here, over to Sunshine.

I assume there will need to be some tweaks to the tests CMakeLists.txt as well, but I will run the workflow anyway.

CMakeLists.txt Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
src/displaydevice/libddplaceholder.cpp Show resolved Hide resolved
src/platf/libplatfplaceholder.cpp Outdated Show resolved Hide resolved
tests/fixtures/fixtures.cpp Outdated Show resolved Hide resolved
tests/CMakeLists.txt Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.66%. Comparing base (35ca85a) to head (9133c38).

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #17       +/-   ##
===========================================
+ Coverage   45.45%   66.66%   +21.21%     
===========================================
  Files           5        2        -3     
  Lines         154        3      -151     
  Branches       89        1       -88     
===========================================
- Hits           70        2       -68     
+ Misses          7        0        -7     
+ Partials       77        1       -76     
Flag Coverage Δ
Windows 66.66% <ø> (+21.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/common/include/displaydevice/logging.h 50.00% <ø> (ø)
...indows/include/displaydevice/windows/winapilayer.h 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

@FrogTheFrog FrogTheFrog marked this pull request as ready for review May 2, 2024 15:01
tests/CMakeLists.txt Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
FrogTheFrog and others added 2 commits May 2, 2024 19:20
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
@ReenigneArcher ReenigneArcher merged commit 5674b70 into LizardByte:master May 2, 2024
15 of 16 checks passed
This was referenced May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants