-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Modernize cmake #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have cmake experience outside of Sunshine, but the approach seems good overall. Might be good to eventually port what we end up with here, over to Sunshine.
I assume there will need to be some tweaks to the tests CMakeLists.txt as well, but I will run the workflow anyway.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #17 +/- ##
===========================================
+ Coverage 45.45% 66.66% +21.21%
===========================================
Files 5 2 -3
Lines 154 3 -151
Branches 89 1 -88
===========================================
- Hits 70 2 -68
+ Misses 7 0 -7
+ Partials 77 1 -76
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Co-authored-by: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Description
Modernize CMake by using recommended functions and patterns
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.