Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): properly handle boolean json responses #3626

Merged

Conversation

ReenigneArcher
Copy link
Member

Description

I forgot to check the UI for string boolean values in #3544. This PR address that, and also changes from loose comparison to strict comparison in several places.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher ReenigneArcher changed the title fix(ui)properly handle boolean json responses fix(ui): properly handle boolean json responses Feb 2, 2025
@ReenigneArcher ReenigneArcher force-pushed the fix/ui/properly-handle-boolean-json-responses branch from 172904d to 135f13f Compare February 2, 2025 17:04
@ReenigneArcher ReenigneArcher enabled auto-merge (squash) February 2, 2025 17:04
Copy link

sonarqubecloud bot commented Feb 2, 2025

Please retry analysis of this Pull-Request directly on SonarQube Cloud

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.62%. Comparing base (a995e57) to head (135f13f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #3626     +/-   ##
=========================================
  Coverage   11.62%   11.62%             
=========================================
  Files          93       93             
  Lines       17319    17319             
  Branches     8085     8085             
=========================================
  Hits         2014     2014             
- Misses      12823    14710   +1887     
+ Partials     2482      595   -1887     
Flag Coverage Δ
Linux 11.30% <ø> (ø)
Windows 13.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 31 files with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit 6efc687 into master Feb 2, 2025
37 checks passed
@ReenigneArcher ReenigneArcher deleted the fix/ui/properly-handle-boolean-json-responses branch February 2, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpair devices table empty
1 participant