Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

refactor: start separating core logic into independent script files #1

Merged
merged 8 commits into from
Dec 16, 2021

Conversation

kwvg
Copy link
Member

@kwvg kwvg commented Nov 21, 2021

Known Regressions

  • arp303.mp3 upon completion will no longer display "thank you for trying this demo"

Build Instructions

# This will clone HSModule indirectly
git clone https://github.com/LiveEnhancementSuite/LESforMacOS --recurse-submodules 

# Go to where HSModule is stored
cd LESforMacOS/extensions/les

# Fetch the latest from this branch
git fetch origin 
git checkout origin/refactor

# Go back to LESforMacOS
cd ../..

# Build project
./scripts/build.sh clean
./scripts/build.sh build

@JonDum
Copy link

JonDum commented Nov 22, 2021

This is some great stuff so far. Scripts look much more clean and maintainable.

@kwvg kwvg force-pushed the refactor branch 2 times, most recently from bef9b64 to 7da8c39 Compare November 30, 2021 10:07
@kwvg
Copy link
Member Author

kwvg commented Nov 30, 2021

@JonDum, resolved the missing assets problem by modifying Xcode project over at LESforMacOS and resolved missing configuration files in latest push!

Confirmation on Monterey so we can wrap this up and get a release? 🙂

@kwvg kwvg marked this pull request as ready for review December 16, 2021 13:04
@kwvg kwvg merged commit 92a903b into develop Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants