Solana 2 (for real this time) #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aursen
requested changes
Oct 11, 2024
Aursen
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing #76 with this because that is stuck in rebase hell.
I had to do something a bit silly with
handle_sysvarbecause the methods to write to individual fields haven't yet been restored to Solana 2.0. For now we just wipe the whole sysvar cache and rebuild it every time someone writes to a sysvar. Shouldn't matter too much.I also reduced the NUM_GREETINGS const in the tests that use solana-program-test because it started breaking at higher numbers. That issue is entirely with solana-program-test so we don't care.
The first commit will be useful to refer to when Solana 2.1 comes out. Thanks to @OliverNChalk for doing some leg work there in #94
Closes #94
Closes #76