LF-4388 animal details sub components handle edit and readonly modes #3485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ID LockedInput, mode prop, and update Storybook
Add breed filtering and clearing, and update stories
For now this is only non-interactivity; don't yet know if a separate disabled style is required
This is to keep the add Storybook stories resembling their initial appearance in app
kathyavini
requested review from
antsgar and
SayakaOno
and removed request for
a team
SayakaOno
approved these changes
Oct 3, 2024
antsgar
approved these changes
Oct 3, 2024
| @@ -111,6 +101,7 @@ export default function AddAnimalsFormCard({ | |||
| onTypeChange={(option) => { | |||
| trigger(`${namePrefix}${BasicsFields.TYPE}`); | |||
| onTypeChange?.(option); | |||
| breedSelectRef?.current?.clearValue(); | |||
There was a problem hiding this comment.
We possibly don't need a ref here at all,
resetField(`${namePrefix}${BasicsFields.BREED}`, { defaultValue: null });seems to do the trick.
Also, not related to this PR, but do we need a ref for the UUID value? Couldn't we set it in the useEffect hook without storing it in a ref?
| @@ -42,6 +43,7 @@ type CommonProps = { | |||
| label?: string; | |||
| optional?: boolean; | |||
| defaultUrl?: string; | |||
| disabled?: boolean; | |||
There was a problem hiding this comment.
Should we call this isDisabled to make it consistent with the other changes?
| <div className={clsx(styles.sectionWrapper, mode === 'edit' && styles.edit)}> | ||
| {(mode === 'readonly' || mode === 'edit') && ( | ||
| <> | ||
| {/* @ts-ignore */} |
There was a problem hiding this comment.
I'm not getting any errors when removing this, do we need it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds two more modes (
readonlyandedit) to the subcomponent cards that display animal details (the original has been designatedadd). This PR also:readonlymode) to custom form elements that were missing them:Jira link: https://lite-farm.atlassian.net/browse/LF-4388
Type of change
How Has This Been Tested?
Checklist: