LF-4226 fix clear filters button does not clear filters #3474
+43
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-wu01
commented
Sep 24, 2024
| @@ -116,7 +116,7 @@ export const FilterMultiSelectV2 = ({ | |||
|
|
|||
| useEffect(() => { | |||
| if (shouldReset) { | |||
| setValue(options.filter((option) => option.default)); | |||
| setValue([]); | |||
There was a problem hiding this comment.
The default filters in options are the filters that were initially active when the filter modal is opened, empty array removes all selected options
kevin-wu01
commented
Sep 24, 2024
| @@ -14,7 +14,14 @@ | |||
| */ | |||
|
|
|||
| // In tempStateReducer > filterReducer | |||
| export type ReduxFilterEntity<FilterKey extends string = string> = Record<FilterKey, FilterState>; | |||
| export type ReduxFilterEntity<FilterKey extends string = string> = Record<FilterKey, FilterState> & | |||
There was a problem hiding this comment.
Unlike the other filters, the date filters have a string type. In order to set the filter inactive the filter value needs to be set to undefined rather than using an active flag. I need to explicitly specify this type here in order to reset to undefined in FilterPage/index.tsx.
kevin-wu01
requested review from
antsgar and
kathyavini
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue where clicking "clear all filters" in the filter modal has no effect in updating the filters. The changes are based on a previous PR #3218 with some additional edits. I explored an alternative solution in #3440 that clears the filters using a useEffect in every filter but I figured this method of handling the logic in one place would be better.
Jira link: LF-4226
Type of change
How Has This Been Tested?
Tested changes on the following pages: crop catalogue, crop variety, documents, tasks
Checklist: