Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run API tests on patch branches #3465

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

kathyavini
Copy link
Collaborator

Description

As dicussed this morning, just adjusting our API tests GitHub actions workflow to trigger on pushes to branches that match the pattern patch/** Syntax from here.

Still not sure whether it needs to go on integration, patch/translation, or both in order to trigger, but probably both? Starting with integration as it also has the node bump.

Jira link: none

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@kathyavini kathyavini added the enhancement New feature or request label Sep 19, 2024
@kathyavini kathyavini self-assigned this Sep 19, 2024
@kathyavini kathyavini requested review from a team as code owners September 19, 2024 22:00
@kathyavini kathyavini requested review from antsgar and Duncan-Brain and removed request for a team September 19, 2024 22:00
@Duncan-Brain
Copy link
Collaborator

Lets try it!

@kathyavini kathyavini added this pull request to the merge queue Sep 19, 2024
Merged via the queue into integration with commit d56791e Sep 19, 2024
5 checks passed
kathyavini added a commit that referenced this pull request Sep 19, 2024
…ches-integration

Run API tests on patch branches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants