Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LF-4440 cannot repeat management plan with deleted and re-added task products #3457

Conversation

Duncan-Brain
Copy link
Collaborator

@Duncan-Brain Duncan-Brain commented Sep 18, 2024

Description

Repairs the ability to repeat a management plan where the user created a soil amendment task in which they edited the tasks products a specific way.

  • Uses the filterDeleted modifier.

Jira link: LF-4440

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@Duncan-Brain Duncan-Brain added the bug Something isn't working label Sep 18, 2024
@Duncan-Brain Duncan-Brain self-assigned this Sep 18, 2024
@Duncan-Brain Duncan-Brain requested review from a team as code owners September 18, 2024 19:29
@Duncan-Brain Duncan-Brain requested review from kathyavini and removed request for a team September 18, 2024 19:29
@Duncan-Brain Duncan-Brain changed the title USes the filterDeleted modifier to creat the repeatable graph LF-4440 cannot repeat management plan with deleted and re-added task products Sep 18, 2024
…nt-plan-with-deleted-and-re-added-soil-amnedment-task-product-with-same-id
@Duncan-Brain
Copy link
Collaborator Author

Updated base with merge to get automated tests going.

@kathyavini kathyavini merged commit 2c0a64c into patch/translations Sep 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants