Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LF-4419 Add the three new welcome screen SVGs #3444

Conversation

kathyavini
Copy link
Collaborator

Description

Adds the three new SVGs created by Loïc to app.

Jira link: https://lite-farm.atlassian.net/browse/LF-4419

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@kathyavini kathyavini added the enhancement New feature or request label Sep 16, 2024
@kathyavini kathyavini self-assigned this Sep 16, 2024
@kathyavini kathyavini requested review from a team as code owners September 16, 2024 17:18
@kathyavini kathyavini requested review from Duncan-Brain and antsgar and removed request for a team September 16, 2024 17:18
@antsgar
Copy link
Collaborator

antsgar commented Sep 16, 2024

@kathyavini because this change is so simple and we have a release tomorrow, I think you can go ahead and merge with just one approval

@kathyavini kathyavini merged commit 881a3f6 into patch/translations Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants