LF-4438 Language dropdown ruins layout of page #3443
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I didn't realize (sorry I think it was mentioned but I wasn't looking at the right part of the screen!) how badly the side menu jumps when the language dropdown is opened! Even with just German added, the effect is unpleasant enough I would recommend trying to fix this for release.
Luckily what @antsgar suggested as ideal behaviour is already an available prop on the ReactSelect. I think the only question would be whether we want to add it to language in particular or the base Select across the board. I vote for across the board, not including the Unit or CreatableSelect, but am happy to discuss on Monday.
Jira link: https://lite-farm.atlassian.net/browse/LF-4438
Type of change
How Has This Been Tested?
Checklist: