Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LF-4438 Language dropdown ruins layout of page #3443

Merged

Conversation

kathyavini
Copy link
Collaborator

@kathyavini kathyavini commented Sep 14, 2024

Description

I didn't realize (sorry I think it was mentioned but I wasn't looking at the right part of the screen!) how badly the side menu jumps when the language dropdown is opened! Even with just German added, the effect is unpleasant enough I would recommend trying to fix this for release.

Luckily what @antsgar suggested as ideal behaviour is already an available prop on the ReactSelect. I think the only question would be whether we want to add it to language in particular or the base Select across the board. I vote for across the board, not including the Unit or CreatableSelect, but am happy to discuss on Monday.

Jira link: https://lite-farm.atlassian.net/browse/LF-4438

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@kathyavini kathyavini added bug Something isn't working enhancement New feature or request labels Sep 14, 2024
@kathyavini kathyavini self-assigned this Sep 14, 2024
@kathyavini kathyavini requested review from a team as code owners September 14, 2024 01:26
@kathyavini kathyavini requested review from Duncan-Brain and removed request for a team September 14, 2024 01:26
Copy link
Collaborator

@Duncan-Brain Duncan-Brain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for across the board !

Edge cases for Denis would likely be select boxes at the top or bottom of forms?

@kathyavini kathyavini merged commit 84ea263 into patch/translations Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants