New Crowdin translations api_email_templates #3407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiteFarm-eng
requested review from
Duncan-Brain and
kathyavini
and removed request for
a team
Duncan-Brain
reviewed
Sep 3, 2024
| @@ -92,7 +92,7 @@ | |||
| "SUBJECT": "sus documentos de certificación de LiteFarm", | |||
| "HI": "Hola", | |||
| "GET_YOUR_EXPORT": "Obtener documentos", | |||
| "LANGUAGE_DELAY": "Los cultivos e insumos en el reporte estan en inglés, pero muy pronto estara disponible en español. Pedimos disculpas por los inconvenientes." | |||
There was a problem hiding this comment.
This problem again where English is an empty string because english is supported and this string explains why the other language is not supported. Might need to manually add this back in crowdin or something.
There was a problem hiding this comment.
So it hasn't been translated in the new languages either then? Yeah we need a better code set up for this. I'll make a ticket.
Edit: Ticket here
kathyavini
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
@Duncan-Brain it doesn't solve the problem of the new languages not having this string and in the dedicated ticket a better solution should be found, but I just reverted the deletion of LANGUAGE_DELAY so we can merge the email templates in the other languages.
Duncan-Brain
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Crowdin pull request with translations of api_email_templates