Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LF-4349 German Translation Branch for CrowdIn #3351

Closed
wants to merge 1 commit into from

Conversation

kathyavini
Copy link
Collaborator

@kathyavini kathyavini commented Jul 30, 2024

DON'T MERGE; FOR CROWDIN ONLY

Description

This pulls the public/locales/de folder from

for uploading to CrowdIn. Note that the PR has other code changes that will be useful to refer to when we start supporting other languages in app (and not merely in CrowdIn), but right now I'm just seeing about getting the strings into CrowdIn.

Jira link: https://lite-farm.atlassian.net/browse/LF-4349

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@kathyavini kathyavini added the enhancement New feature or request label Jul 30, 2024
@kathyavini kathyavini self-assigned this Jul 30, 2024
@kathyavini kathyavini requested review from a team as code owners July 30, 2024 17:32
@kathyavini kathyavini requested review from Duncan-Brain and SayakaOno and removed request for a team July 30, 2024 17:32
@kathyavini kathyavini closed this Jul 30, 2024
@kathyavini kathyavini removed the enhancement New feature or request label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant