Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Crowdin translations #3321

Conversation

Duncan-Brain
Copy link
Collaborator

New Crowdin pull request with translations

@Duncan-Brain Duncan-Brain requested review from a team as code owners July 22, 2024 18:13
@Duncan-Brain Duncan-Brain requested review from SayakaOno and kathyavini and removed request for a team July 22, 2024 18:13
Copy link
Collaborator Author

@Duncan-Brain Duncan-Brain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Safe to ignore.

But it would be good to come back to this and see if the Language delay (ie. sorry this certification stuff is in english) is still accurate.

It is another weird one -- the english is an empty string since english is good. But why it didn't upload translations properly is a mystery.

Ignore for now I think is best.

@github-actions github-actions bot force-pushed the l10n_crowdin_translations_patch/3.6.5_api_email_templates branch from 6d3e190 to 2e91138 Compare July 24, 2024 15:43
@github-actions github-actions bot force-pushed the l10n_crowdin_translations_patch/3.6.5_api_email_templates branch from 2e91138 to ab6a70c Compare July 25, 2024 14:18
@Duncan-Brain
Copy link
Collaborator Author

I fixed the LANGUAGE_DELAY strings in crowdin -- so this looks good to merge for me as a normalization merge.

There is one deleted spanish key GET_EXPORT which seems correct to delete.

@SayakaOno
Copy link
Collaborator

Which branch should we merge this PR into? Integration??

@kathyavini
Copy link
Collaborator

Which branch should we merge this PR into? Integration??

Ummm... 3.6.6 patch maybe? If we merge to integration we have to upload with translations + approve on integration but we cannot do that; it's chock full of MISSING tags...

@kathyavini kathyavini changed the base branch from patch/3.6.5 to patch/3.6.6 July 30, 2024 21:05
@kathyavini kathyavini changed the base branch from patch/3.6.6 to patch/translations July 30, 2024 21:08
@kathyavini kathyavini merged commit c8ca66c into patch/translations Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants