Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Localization, adds multi-language support #99

Merged
merged 29 commits into from
Jul 25, 2021

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Jul 24, 2021

Category: Feature

Overview
I think that it is important for everyone to be able to comfortable use Dashy, even if English is not their native language.
This PR implements the language-switching functionality. All text within the application has been extracted to a single locales file, and this file can then be duplicated and translated into other languages.

Unfortunately, at this time I wasn't able to include any other language, since I only speak English 😞 but now that the functionality is in place, I can look into getting it translated very easily :)

Issue Number N/A

New Vars
The only new variable is appConfig.language, an optional property to pre-load a given language. The language can also be updated through the UI once the app is running.

Field Type Required Description
language string Optional The 2 (or 4-digit) ISO 639-1 code for your language, e.g. en or en-GB. This must be a language that the app has already been translated into. If your language is unavailable, Dashy will fallback to English. By default Dashy will attempt to auto-detect your language, although this may not work on some privacy browsers.

Screenshot N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance

@netlify
Copy link

netlify bot commented Jul 24, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: 51641d0

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/60fd5bbbae6e380007b81372

😎 Browse the preview: https://deploy-preview-99--dashy-dev.netlify.app/

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2021

yarn.lock changes

Summary

Status Count
ADDED 93
UPDATED 10
DOWNGRADED 1
Click to toggle table visibility
Name Status Previous Current
@architect/asap ADDED - 3.13.8
@architect/create ADDED - 1.4.3
@architect/hydrate ADDED - 1.10.2
@architect/inventory ADDED - 1.4.4
@architect/parser ADDED - 3.0.1
@architect/sandbox ADDED - 3.7.4
@architect/utils ADDED - 2.1.3
@begin/hashid ADDED - 1.0.0
@sindresorhus/is ADDED - 0.14.0
@szmarczak/http-timer ADDED - 1.1.2
abstract-leveldown ADDED - 6.2.3
acorn-loose ADDED - 8.1.0
acorn UPDATED 7.4.1 8.4.1
ansi-align ADDED - 3.0.0
aws-sdk ADDED - 2.880.0
boxen ADDED - 5.0.1
buffer-crc32 ADDED - 0.2.13
buffer UPDATED 4.9.2 5.7.1
cacheable-request ADDED - 6.1.0
ci-info UPDATED 1.6.0 2.0.0
cli-boxes ADDED - 2.2.1
clone-response ADDED - 1.0.2
configstore ADDED - 5.0.1
cpr ADDED - 3.0.1
crypto-random-string ADDED - 2.0.0
decompress-response ADDED - 3.3.0
deep-extend ADDED - 0.6.0
defer-to-connect ADDED - 1.1.3
deferred-leveldown ADDED - 5.3.0
defined ADDED - 0.0.0
depstatus ADDED - 1.1.1
dotenv UPDATED 8.6.0 10.0.0
duplexer3 ADDED - 0.1.4
dynalite ADDED - 3.2.1
encoding-down ADDED - 6.3.0
escape-goat ADDED - 2.1.1
global-dirs ADDED - 3.0.0
got ADDED - 9.6.0
has-yarn ADDED - 2.1.0
http-cache-semantics ADDED - 4.1.0
immediate ADDED - 3.2.3
import-lazy ADDED - 2.1.0
ini ADDED - 1.3.8
is-ci UPDATED 1.2.1 2.0.0
is-installed-globally ADDED - 0.4.0
is-npm ADDED - 5.0.0
is-path-inside UPDATED 2.1.0 3.0.3
is-yarn-global ADDED - 0.3.0
json-buffer ADDED - 3.0.0
keyv ADDED - 3.1.0
latest-version ADDED - 5.1.0
lazy ADDED - 1.0.11
level-codec ADDED - 9.0.2
level-concat-iterator ADDED - 2.0.1
level-errors ADDED - 2.0.1
level-iterator-stream ADDED - 4.0.2
level-option-wrap ADDED - 1.1.0
level-supports ADDED - 1.0.1
leveldown ADDED - 5.6.0
levelup ADDED - 4.4.0
lock ADDED - 1.1.0
lowercase-keys ADDED - 2.0.0
ltgt ADDED - 2.2.1
memdown ADDED - 5.1.0
mimic-response ADDED - 1.0.1
napi-macros ADDED - 2.0.0
node-gyp-build ADDED - 4.1.1
node-watch ADDED - 0.7.1
normalize-url UPDATED 3.3.0 4.5.1
p-cancelable ADDED - 1.1.0
package-json ADDED - 6.5.0
path-sort ADDED - 0.1.0
prepend-http UPDATED 1.0.4 2.0.0
pupa ADDED - 2.1.1
queue-microtask ADDED - 1.2.3
rc ADDED - 1.2.8
reachdown ADDED - 1.1.0
registry-auth-token ADDED - 4.2.1
registry-url ADDED - 5.1.0
responselike ADDED - 1.0.2
router ADDED - 1.3.5
run-parallel ADDED - 1.2.0
run-series ADDED - 1.1.9
run-waterfall ADDED - 1.1.7
semver-diff ADDED - 3.1.1
server-destroy ADDED - 1.0.1
setprototypeof UPDATED 1.1.1 1.2.0
sha ADDED - 3.0.0
strip-json-comments DOWNGRADED 3.1.1 2.0.1
subleveldown ADDED - 5.0.1
symlink-or-copy ADDED - 1.3.1
to-readable-stream ADDED - 1.0.0
tree-kill ADDED - 1.2.2
typedarray-to-buffer ADDED - 3.1.5
unique-string ADDED - 2.0.0
update-notifier ADDED - 5.1.0
url-parse-lax ADDED - 3.0.0
vue-i18n ADDED - 8.25.0
widest-line ADDED - 3.1.0
write-file-atomic ADDED - 3.0.3
ws UPDATED 6.2.2 7.5.3
xdg-basedir ADDED - 4.0.0
xml2js ADDED - 0.4.19
xmlbuilder ADDED - 9.0.7

@Lissy93 Lissy93 merged commit 92b52e8 into master Jul 25, 2021
@Lissy93 Lissy93 deleted the FEATURE/localization branch July 25, 2021 12:45
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant