-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix some code locations that should probably use BASE_URL #858
Conversation
✅ Deploy Preview for dashy-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Changes preview: |
Welp, this is only enough to do the job (and then only mostly; the call to save the configuration is still busted, as is a font load) if |
…d that the BASE_URL typically must end with a `/` in Vue apps)
This has quickly become a spam-fest / game of whack-a-mole / yeah I don't 100% know what I'm doing here -- and I'd rather take the time to figure it out properly. And then squash my commits. Sorry 😅 |
Thank you for contributing to Dashy! So that your PR can be handled effectively, please populate the following fields (delete sections that are not applicable)
Category:
Bugfix
Overview
A smol change to allow dashy to be fully run in a non-root (URL) context, such as https://example.com/cool-apps/dashy (as opposed to, say, https://dashy.example.com), with all resources being loaded from that context.
Issue Number #857
Code Quality Checklist (Please complete)