Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add group and user in dockerfile to run container as unprivileged #495

Merged
merged 2 commits into from
Feb 19, 2022

Conversation

Singebob
Copy link
Contributor

@Singebob Singebob commented Feb 18, 2022

Singebob Medium Singebob /master → Lissy93/dashy Commits: 2 | Files Changed: 1 | Additions: 16 Label

Thank you for contributing to Dashy! So that your PR can be handled effectively, please populate the following fields (delete sections that are not applicable)

Category: Bugix

One of: Bugfix / Feature / Code style update / Refactoring Only / Build related changes / Documentation / Other (please specify)

Overview

Briefly outline your new changes...

Add group and user in dockerfile to run container as unprivileged

Issue Number
#340

New Vars

If you've added any new build scripts, environmental variables, config file options, dependency or devDependency, please outline here

Add env in dockerfile:

  • USER
  • UID
  • GID

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@Singebob Singebob requested a review from Lissy93 as a code owner February 18, 2022 07:25
@netlify
Copy link

netlify bot commented Feb 18, 2022

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: bbbcd09

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/620f4ba7edd31900074dd3c0

😎 Browse the preview: https://deploy-preview-495--dashy-dev.netlify.app

@viezly
Copy link

viezly bot commented Feb 18, 2022

Changes preview:

Legend:

👀 Review pull request on Viezly

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you so much 🙌

@Lissy93 Lissy93 merged commit 5aff97a into Lissy93:master Feb 19, 2022
@Lissy93
Copy link
Owner

Lissy93 commented Feb 20, 2022

I'm going to temporarily revert this, until I've got a chance to update the docs, as users are facing issues when they don't specify UID/GUID

@Lissy93
Copy link
Owner

Lissy93 commented Feb 20, 2022

Reopened in: #502

@bmonty bmonty mentioned this pull request Apr 21, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants