Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Section Height (colourful theme) #462

Merged
merged 9 commits into from
Feb 1, 2022
Merged

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Jan 31, 2022

🐛 Fix Medium Lissy93 /FIX/section-height → Lissy93/dashy Commits: 9 | Files Changed: 8 | Additions: 21

Category: UI Bugfix

Overview

  • 🐛 67326ed - cutToHeight was missing from the schema, added it
  • 🐛 6b9484a - Removed the full height CSS from colorful theme file
  • ⚡️ e472d91 - Improved config validation warnings in JSON editor
  • 🩹 d07a5f7 - Removes empty Keycloak block from appConfig editor
  • ⚡️ a5944c1 - Adds typechecking to search and clear search for Safari

Issue Number #461

New Vars N/A

Screenshot N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@netlify
Copy link

netlify bot commented Jan 31, 2022

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: 947d616

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/61f98a6406ab7e0007565283

😎 Browse the preview: https://deploy-preview-462--dashy-dev.netlify.app

@liss-bot liss-bot added the 🦋 Bug Fix [PR] Code includes bug fixes label Jan 31, 2022
@viezly
Copy link

viezly bot commented Jan 31, 2022

Changes preview:

Legend:

👀 Review pull request on Viezly

@Lissy93 Lissy93 merged commit 0a639b0 into master Feb 1, 2022
@Lissy93 Lissy93 deleted the FIX/section-height branch February 1, 2022 19:53
@Lissy93 Lissy93 mentioned this pull request Feb 9, 2022
4 tasks
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦋 Bug Fix [PR] Code includes bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants