[FIX] Couple of minor issues #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #366. This issue was caused by item IDs not being regenerated after the previous move, causing the second part of the move operation (delete previous) to fail. It was fixed by calling regenerate item IDs after item removal
Closes #377. This bg was caused by adding items without a title, meaning an ID could not be calculated. The solution was to add a validtion check to ensure that a title is specified befire saving
|
✔️ Deploy Preview for dashy-dev ready! 🔨 Explore the source changes: f1239f3 🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/61cce56df4c4c200076ccd2a 😎 Browse the preview: https://deploy-preview-388--dashy-dev.netlify.app/ |
This comment has been minimized.
This comment has been minimized.
|
Issues |
This was referenced Dec 29, 2021
Closed
|
The fix for this issue has now been released in Dashy 2.0.0 ✨ If you haven't done so already, please update your instance to Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project. |
asterling8516
pushed a commit
to asterling8516/dashy
that referenced
this pull request
Nov 23, 2023
Co-authored-by: Dashboard Icons Bot <noreply@walkx.fyi>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category: Bug fixes and minor improvements
Overview
Issue Number #366 #377
New Vars N.A
Screenshot N/A
Code Quality Checklist (Please complete)