Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved docker deployments #26

Merged
merged 9 commits into from
Jun 11, 2021
Merged

Improved docker deployments #26

merged 9 commits into from
Jun 11, 2021

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Jun 11, 2021

Please check the type of change your PR introduces:

  • Build-related changes
  • Slight UI improvements

Issue Number (if applicable): N/A

Briefly outline your changes:

  • Adds healthceck into Docker container, and writes a node file to service said check
  • Changes default port in docker-compose, as 8080 is commonly used by other apps
  • Adds 1-Click deploy using PWD into the readme
  • Updates dependencies
  • Adds a getting started guide to the docs
  • Adds splash screen for first load
  • Deleted unused assets
  • Fixes lint errors in server.js and validate-config.js, and adds linting as a pre-commit hook

Before submitting, please ensure that:

  • Must be backwards compatible
  • All lint checks and tests must pass
  • If a new option in the the config file is added, it needs to be added into the schema, and documented in the configuring guide
  • If a new dependency is required, it must be essential, and it must be thoroughly checked out for security or efficiency issues

@Lissy93 Lissy93 merged commit cd274e2 into master Jun 11, 2021
@Lissy93 Lissy93 deleted the improved-docker-deployments branch June 11, 2021 18:15
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant