Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Multi-Search with Custom Bangs #224

Merged
merged 9 commits into from
Sep 11, 2021
Merged

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Sep 11, 2021

Lissy93 /FEATURE/multi-search → Lissy93/dashy Commits: 9 | Files Changed: 10 | Additions: 89 ✨ Feature Powered by Pull Request Badge

Category: Feature

Overview
Implements support for multiple search engines simultaneously, with user customizable bangs

Issue Number #206

New Vars

appConfig.webSearch (optional)

Field Type Required Description
searchBangs object Optional A key-value-pair set of custom search bangs for redirecting query to a specific app or search engine. The key of each should be the bang you will type (typically starting with /, ! or :), and value is the destination, either as a search engine key (e.g. reddit) or a URL with search parameters (e.g. https://en.wikipedia.org/w/?search=)

Example:

appConfig:
  webSearch:
    searchEngine: 'duckduckgo'
    openingMethod: 'newtab'
    searchBangs:
      /r: reddit
      /a: https://www.amazon.co.uk/s?k=
      '!w': https://en.wikipedia.org/w/?search=

Screenshot N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@Lissy93 Lissy93 added the ✨ New Feature [PR] Contains implementation of a new feature label Sep 11, 2021
@netlify
Copy link

netlify bot commented Sep 11, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: ee56183

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/613d0d071a374c000755d411

😎 Browse the preview: https://deploy-preview-224--dashy-dev.netlify.app/

@viezly
Copy link

viezly bot commented Sep 11, 2021

Changes preview:

👀 Review pull request on Viezly

@lgtm-com
Copy link

lgtm-com bot commented Sep 11, 2021

This pull request introduces 1 alert when merging 688dece into 51e2129 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@liss-bot
Copy link
Collaborator

Hi Lissy93! Thank you for contributing to Dashy! ✨

When making changes to the documentation, be sure to double check that:

  • Link and images URLs properly resolve
  • Your spelling and grammar is correct
  • Any markdown formatting is valid

I'm a bot, and this is an automated comment 🤖

@liss-bot
Copy link
Collaborator

Hi Lissy93! Thank you for contributing to Dashy! ✨

When making changes to the documentation, be sure to double check that:

  • Link and images URLs properly resolve
  • Your spelling and grammar is correct
  • Any markdown formatting is valid

I'm a bot, and this is an automated comment 🤖

@liss-bot
Copy link
Collaborator

Hi Lissy93! Thank you for contributing to Dashy! ✨

Don't forget to verify they the config validator script responds correctly to your new attribute.


I'm a bot, and this is an automated comment 🤖

@liss-bot
Copy link
Collaborator

Hi Lissy93! Thank you for contributing to Dashy! ✨

Don't forget to verify they the config validator script responds correctly to your new attribute.


I'm a bot, and this is an automated comment 🤖

@Lissy93 Lissy93 merged commit fd3c043 into master Sep 11, 2021
@Lissy93 Lissy93 deleted the FEATURE/multi-search branch September 11, 2021 20:24
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Closes Lissy93#224

Signed-off-by: Bjorn Lammers <walkxnl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ New Feature [PR] Contains implementation of a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants