Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Adds Keycloak support #174

Merged
merged 12 commits into from
Aug 21, 2021
Merged

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Aug 21, 2021

Lissy93 /FEATURE/auth-keycloak-support → Lissy93/dashy Commits: 12 | Files Changed: 12 | Additions: 242 Powered by Pull Request Badge

Category: Feature

Overview
Adds support for secure authentication using Keycloak, plus docs
Also refactors the auth attribute, which later down the line will involve breaking changes

Issue Number #33

New Vars
Under appConfig.auth.keycloak

Field Type Required Description
serverUrl string Required The URL (or URL/ IP + Port) where your keycloak server is running
realm string Required The name of the realm (must already be created) that you want to use
clientId string Required The Client ID of the client you created for use with Dashy

Screenshot N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@netlify
Copy link

netlify bot commented Aug 21, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: 4baa457

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/61217de5bd04dc00084ec5bc

😎 Browse the preview: https://deploy-preview-174--dashy-dev.netlify.app

@github-actions
Copy link
Contributor

yarn.lock changes

Click to toggle table visibility
Name Status Previous Current
js-sha256 ADDED - 0.9.0
keycloak-js ADDED - 15.0.2

@viezly
Copy link

viezly bot commented Aug 21, 2021

Changes preview:

👀 Review pull request on Viezly

@Lissy93 Lissy93 merged commit fea630f into master Aug 21, 2021
@Lissy93 Lissy93 deleted the FEATURE/auth-keycloak-support branch August 21, 2021 22:35
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Signed-off-by: Bjorn Lammers <walkxnl@gmail.com>
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Closes Lissy93#174

Signed-off-by: Bjorn Lammers <walkxnl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant