Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCKER] Update Dockerfiles #160

Merged
merged 7 commits into from
Aug 15, 2021
Merged

[DOCKER] Update Dockerfiles #160

merged 7 commits into from
Aug 15, 2021

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Aug 15, 2021

Lissy93 /DOCKER/revert-image → Lissy93/dashy Commits: 7 | Files Changed: 8 | Additions: 55 Powered by Pull Request Badge

Category: Build related changes

Overview
Reverts the main Dockerfile to the previous version due to memory consumption issues that were raised. The new image is still available but moved into the ./docker/ directory. I also moved the alternate dockerfiles for other architectures into this directory to keep the project root less cluttered. I updated the build scripts to take account of this.

Issue Number #136

New Vars N/A

Screenshot N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@netlify
Copy link

netlify bot commented Aug 15, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: c152b4f

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/6118fbd7770f6000077fe982

😎 Browse the preview: https://deploy-preview-160--dashy-dev.netlify.app

@viezly
Copy link

viezly bot commented Aug 15, 2021

Changes preview:

👀 Review pull request on Viezly

@Lissy93 Lissy93 merged commit 6f8ab4a into master Aug 15, 2021
@Lissy93 Lissy93 deleted the DOCKER/revert-image branch August 15, 2021 11:41
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Closes Lissy93#160

Signed-off-by: Bjorn Lammers <walkxnl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant