Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Anonymous optional error reporting #112

Merged
merged 9 commits into from
Aug 1, 2021

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Aug 1, 2021

Category: Enhancement

Overview

  • Adds Privacy & Security docs
  • Adds an optional, off by default method of getting crash reports
  • This can be enabled in appConfig.enableErrorReporting, and will not be used at all unless explicitly activated by user
  • This is needed for when a user raises a bug which is hard to fix
  • Also improves robustness of config accumulator, don't throw error when config is missing

Issue Number: N/A

New Vars
enableErrorReporting - boolean Optional
Enable reporting of unexpected errors and crashes. This is off by default, and no data will ever be captured unless you explicitly enable it. Turning on error reporting helps previously unknown bugs get discovered and fixed. Dashy uses Sentry for error reporting. Defaults to false.

Screenshot N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@netlify
Copy link

netlify bot commented Aug 1, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: 78ce2d3

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/610692b824b5e700072758a1

😎 Browse the preview: https://deploy-preview-112--dashy-dev.netlify.app/

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2021

yarn.lock changes

Click to toggle table visibility
Name Status Previous Current
@sentry/browser ADDED - 6.10.0
@sentry/core ADDED - 6.10.0
@sentry/hub ADDED - 6.10.0
@sentry/minimal ADDED - 6.10.0
@sentry/tracing ADDED - 6.10.0
@sentry/types ADDED - 6.10.0
@sentry/utils ADDED - 6.10.0
@sentry/vue ADDED - 6.10.0

@Lissy93 Lissy93 merged commit 01e4c0f into master Aug 1, 2021
@Lissy93 Lissy93 deleted the FEATURE/anonymous-optional-error-reporting branch August 1, 2021 12:56
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Closes Lissy93#112

Signed-off-by: Bjorn Lammers <walkxnl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant