Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outdated yarn.lock #1118

Closed
wants to merge 1 commit into from

Conversation

adamantike
Copy link

@adamantike adamantike commented Feb 22, 2023

adamantike Quick adamantike /fix/outdated-yarn-lock → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: -5 Label Unchecked Tasks

Category: Build related changes

Overview
Issue introduced in #1101, which updated package.json without refreshing the yarn.lock file.

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

Introduced in Lissy93#1101, which updated
`package.json` without refreshing the `yarn.lock` file.
@adamantike adamantike requested a review from Lissy93 as a code owner February 22, 2023 04:51
@vercel
Copy link

vercel bot commented Feb 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
dashy ❌ Failed (Inspect) Feb 22, 2023 at 4:51AM (UTC)

@netlify
Copy link

netlify bot commented Feb 22, 2023

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit fd8723f
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/63f59f4314a8d50008cf28de
😎 Deploy Preview https://deploy-preview-1118--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented Feb 22, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

@adamantike
Copy link
Author

Closing, as this has been applied in 3e35b56

@adamantike adamantike closed this Feb 26, 2023
@adamantike adamantike deleted the fix/outdated-yarn-lock branch February 26, 2023 15:23
@Lissy93
Copy link
Owner

Lissy93 commented Feb 26, 2023

Thanks @adamantike
Really sorry that I missed this, I've got so behind in notifications the last few weeks 😬

@adamantike
Copy link
Author

No problem, glad you fixed it! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants