Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE_REQUEST] Allow setting a target of _top on items #289

Closed
mdcollins05 opened this issue Oct 22, 2021 · 5 comments
Closed

[FEATURE_REQUEST] Allow setting a target of _top on items #289

mdcollins05 opened this issue Oct 22, 2021 · 5 comments
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change ✅ Fixed [ISSUE] Auto-Assigned to Tickets whose fix has been deployed 🔨 Fixed 🛩️ Released 1.9.0

Comments

@mdcollins05
Copy link

Is your feature request related to a problem? If so, please describe.

I use a Firefox extension to set my Dashy page as my new tab page. In doing so, it uses an iframe to display the website. I'd like the links to open in the new tab, so I use the item target option of "sametab" but it doesn't break out of the iframe. This results in the URL bar being blank (which is a feature of the extension) while navigating to the item I've clicked on.

Describe the solution you'd like

Ideally, I'd be able to set a the target to _top. Additionally, setting a default would be awesome, as all my items would have the same setting on them.

Priority

Medium (Would be very useful)

Is this something you would be keen to implement

Maybe

@mdcollins05 mdcollins05 added the 🦄 Feature Request [ISSUE] Suggestion for new feature, update or change label Oct 22, 2021
@liss-bot
Copy link
Collaborator

Welcome to Dashy 👋
It's great to have you here, but unfortunately your ticket has been closed to prevent spam. Before reopening this issue, please ensure the following criteria are met.

Issues are sometimes closed when users:

  • Have only recently joined GitHub
  • Have not yet stared this repository
  • Have not previously interacted with the repo

Before you reopen this issue, please also ensure that:

  • You have checked that a similar issue does not already exist
  • You have checked the documentation for an existing solution
  • You have completed the relevant sections in the Issue template

Once you have verified the above standards are met, you may reopen this issue. Sorry for any inconvenience caused, I'm just a bot, and sometimes make mistakes 🤖

@Lissy93
Copy link
Owner

Lissy93 commented Oct 23, 2021

Heya @mdcollins05, I've implemented this in #292 :)

  • You can now set target: top to use _top (as well as still newtab, sametab, parent, modal or workspace)
  • You can also set defaultOpeningMethod within appConfig to one of those options, which will be applied to all items that don't have the target specifically set

Hope that helps :)

@Lissy93 Lissy93 added the ✅ Fixed [ISSUE] Auto-Assigned to Tickets whose fix has been deployed label Oct 23, 2021
@liss-bot
Copy link
Collaborator

Hello @mdcollins05! It looks like all or part of this issue has now been implemented :) If you're enjoying Dashy, please consider supporting the project- for ways to get involved, see Contributing 💖


I am a bot, and this is an automated message 🤖

@mdcollins05
Copy link
Author

Wow, that was quick! Thanks so much.

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Oct 23, 2021
@Lissy93 Lissy93 removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Oct 23, 2021
@liss-bot
Copy link
Collaborator

The fix for this issue has now been released in Dashy 1.9.0 ✨

If you haven't done so already, please update your instance to 1.9.0 or later. See Dashy 1.9.0 for full info.

Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project.

asterling8516 pushed a commit to asterling8516/dashy that referenced this issue Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change ✅ Fixed [ISSUE] Auto-Assigned to Tickets whose fix has been deployed 🔨 Fixed 🛩️ Released 1.9.0
Projects
None yet
Development

No branches or pull requests

3 participants