Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chrome opening on windows when simply loading the system #21

Merged
merged 2 commits into from
Jan 21, 2023
Merged

Fix chrome opening on windows when simply loading the system #21

merged 2 commits into from
Jan 21, 2023

Conversation

tobyWorland
Copy link
Contributor

  • Support 64bit Chrome and Firefox executables on Windows
  • Use a different method to detect if chrome is present (probe-file since full paths are used and browsers do not end up in $PATH by default on Windows)

@tobyWorland
Support (and prefer) 64bit Chrome and Firefox on Windows
0d4cfad
@tobyWorland
Fix bug where chrome opens on Windows when simply loading the system
7418bee 
This is caused by Windows' Google Chrome not responding to --version
causing it instead to open a new window.
@tobyWorland
Copy link
Contributor Author

Solves bug in issue #20

@tobyWorland tobyWorland mentioned this pull request Jan 20, 2023
Closed
@Symbolics Symbolics merged commit ffd612b into Lisp-Stat:master Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobyWorland @Symbolics