Use chrome in app mode if present, else use the user's default browser #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobyWorland
force-pushed
the
improvement/browser-defaulting
branch
from
0f0bc57 to
b7d104b
Compare
|
@tobyWorland is this ready for review and merge? I see it's marked work in progress and am not sure whether that's because it's not reviewed or because it still needs some more work. |
|
Not ready just yet. I got a little too eager making this pull request. I did have some more changes locally, but did not like how they turned out. I will have something soon. |
tobyWorland
force-pushed
the
improvement/browser-defaulting
branch
from
a126e31 to
0c28f26
Compare
|
Ready for review. |
Symbolics
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the concern of a user not having chrome installed.
If chrome can be found, then we default to using it in application mode to display graphs. Otherwise, we default to using the user's regular browser.
Chrome can also be selected to run in non-application mode, for the use case that came up in issue #14 without having to make chrome your default browser.
Browser specifier type was added to ensure an invalid option is not passed. The types are:
There is no option to put Firefox in application mode as support for this has been dropped by Firefox.