Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Remove usage of storageRead function on Chain actions #2989

Closed
2snEM6 opened this issue Feb 27, 2019 · 0 comments · Fixed by #3018
Closed

Remove usage of storageRead function on Chain actions #2989

2snEM6 opened this issue Feb 27, 2019 · 0 comments · Fixed by #3018
Assignees

Comments

@2snEM6
Copy link
Contributor

2snEM6 commented Feb 27, 2019

Expected behavior

storageRead was intended to make the non-breaking changes for network layer. Any kind of formatting you need for blocks for the APIs, should be done in API module itself. So directly use storage.entities.Block.get, and format the response how the API is required.

Action can be removed and API module can directly perform the same logic itself instead of using the channel to call this action.

Discussed here:
https://github.com/LiskHQ/lisk/pull/2982/files/4667c5aa2129a7b604f2bb45220e62d5c0bee508#r260461947

Actual behavior

storageRead is being used by Chain actions that are called by API module.

Steps to reproduce

Which version(s) does this affect? (Environment, OS, etc...)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants