This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Remove storageRead call from http_api to chain - Closes #2989 #3018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michielmulders
changed the title
shuse2
suggested changes
Mar 4, 2019
| height: parseInt(raw.height), | ||
| previousBlock: raw.previousBlockId, | ||
| numberOfTransactions: parseInt(raw.numberOfTransactions), | ||
| totalAmount: new Bignum(raw.totalAmount), |
There was a problem hiding this comment.
if this is return as a JSON, this should be string, and same for other Bignum instances
2snEM6
suggested changes
Mar 5, 2019
2snEM6
previously approved these changes
Mar 5, 2019
2snEM6
previously approved these changes
Mar 6, 2019
shuse2
previously approved these changes
Mar 6, 2019
MaciejBaj
reviewed
Mar 6, 2019
MaciejBaj
approved these changes
Mar 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
storageReadwas intended to make the non-breaking changes for the network layer. Any kind of formatting you need for blocks for the APIs, should be done in API module itself. So directly usestorage.entities.Block.get, and format the response how the API is required.How did I fix it?
Remove
channel.invokecall tostorageReadinhttp_apimodule and move the API specific formatting logic for a block to thehttp_apimodule.How to test it?
Run tests.
Comments
We can move the functionality of
parseBlockFromDatabaseinto ahelperobject later.Review checklist