Increase coverage on failing modules - Closes #561 #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix "Account not found" error in Delegates - Closes #552
slaweet
suggested changes
Mar 27, 2018
| const settingsUpdated = sinon.spy(); | ||
| const accountUpdated = sinon.spy(); |
There was a problem hiding this comment.
You can define let accountUpdated here, but sinon.spy(); should be inside of beforeEach. The current way, the same spy is used in all its, so the tests are not isolated and can affect each other.
faival
force-pushed
the
561-coverage-on-failing-modules
branch
from
96523a7 to
bd6d5cb
Compare
faival
force-pushed
the
561-coverage-on-failing-modules
branch
from
bd6d5cb to
c477384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
'src/components/setting/setting.js', does not meet coverage threesholds
How did I fix it?
Add missing tests for asserting autoLog, advanceMode, expireTime, settings flags
How to test it?
run the follwoing
assert that settings.js shows the following coverage:
Review checklist