Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase coverage on failing modules - followup #536 #561

Closed
faival opened this issue Mar 15, 2018 · 0 comments
Closed

Increase coverage on failing modules - followup #536 #561

faival opened this issue Mar 15, 2018 · 0 comments
Assignees
@faival

Comments

@faival
Copy link
Contributor

faival commented Mar 15, 2018

Expected behaviour

we should match coverage rules in karma konfig for all modules.

Actual behaviour

some modules are still not being covered:

  • statements (96.3%) src/store/middlewares/savedAccounts.js) threshold (100%)
  • statements (57.14%) /src/components/dialog/index.js) threshold (80%)
  • lines (40%) src/components/dialog/index.js) threshold (80%)
  • functions (40%) src/components/dialog/index.js) threshold (80%)

Steps to reproduce

remove ignore for file src/components/dialog/index.js In karma config and npm run test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@faival faival

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@faival @slaweet