Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unit tests of HOCs - Closes #1443 #1545

Merged
merged 56 commits into from
Dec 11, 2018
Merged

Conversation

massao
Copy link
Contributor

@massao massao commented Dec 6, 2018

What issue have I solved?

-- #1443

How have I implemented/fixed it?

Removed unit test from HOCs and updated the mapDispatchToProps to receive an object.

Some files will be handled separately in #1557

How has this been tested?

After all the changes ran all tests and all have passed with coverage above 80%.

Review checklist

@massao massao self-assigned this Dec 6, 2018
massao added 26 commits December 6, 2018 18:43
@slaweet slaweet changed the base branch from 1.8.0 to development December 11, 2018 10:16
@slaweet slaweet changed the base branch from development to 1.8.0 December 11, 2018 10:16
slaweet
slaweet previously approved these changes Dec 11, 2018
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, @RenatoMassao 👍

@massao massao merged commit 03866a2 into 1.8.0 Dec 11, 2018
@massao massao deleted the 1443-remove-unit-tests-of-HOC branch December 11, 2018 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants