Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unit tests of HOCs - Closes #1443 #1545

Merged
merged 56 commits into from
Dec 11, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
33d5452
:recycle: Remove unit test of settingHOC
massao Dec 6, 2018
71db1e4
:recycle: Remove unit test of settingHOC
massao Dec 6, 2018
d493bf5
:recycle: Remove unit test of accountHOC and skip coverage test on HOC
massao Dec 7, 2018
e113db5
:recycle: Remove unit tests of authInputsHOC
massao Dec 7, 2018
674f305
:recycle: Remove unit test of confirmVotesHOC
massao Dec 7, 2018
e339ec9
:recycle: Remove unit tests of converterHOC
massao Dec 7, 2018
81eb08a
:recycle: Remove unit test of headerHOC
massao Dec 7, 2018
05e091b
:recycle: Remove authenticateHOC unit test and update mapDispatchToProps
massao Dec 7, 2018
a58c5f7
:recycle: Update mapDispatchToProps of currencyGraph
massao Dec 7, 2018
0095436
:recycle: Update mapDispatchToProps of Dashboard
massao Dec 7, 2018
ec78d1d
:recycle: Update mapDIspatchToProps to receive an object
massao Dec 7, 2018
7814993
:recycle: Remove unit tests of loginHOC
massao Dec 7, 2018
36f9488
:recycle: Remove unit test for LoadingBarHOC
massao Dec 7, 2018
f892051
:recycle: Remove unit test of SecondPassphrase: ConfirmationHOC
massao Dec 7, 2018
36a34bb
:recycle: Remove unit tests of RegisterDelegateHOC
massao Dec 7, 2018
40d0070
:recycle: Remove unit test of SecondPassphraseHOC
massao Dec 7, 2018
7d69f1a
:recycle: Remove unit test of confirmHOC
massao Dec 7, 2018
b42cf59
:recycle: Remove unit test of send steps FormHOC
massao Dec 7, 2018
26760f3
:recycle: Remove unit test of sendNew steps confirmHOC
massao Dec 7, 2018
9b525d8
:recycle: Remove unit test of sendNew steps formHOC
massao Dec 7, 2018
d944952
:recycle: Remove unit test of voteUrlProcessorHOC
massao Dec 7, 2018
53c7bfd
:recycle: Remove unit test of votingHOC
massao Dec 7, 2018
73f375d
:recycle: Remove unit test of register and toaster HOC
massao Dec 10, 2018
df03a00
:recycle: Update all mapDispatchToProps to object syntax
massao Dec 10, 2018
e2af450
:recycle: Remove unused code from setting.js
massao Dec 10, 2018
8b8caad
Merge branch '1443-remove-unit-tests-of-HOC' of github.com:LiskHQ/lis…
massao Dec 10, 2018
bd0202e
:recycle: Separate accountTransactions and remove unit test of HOC
massao Dec 10, 2018
da04fe5
Merge branch 'development' of github.com:LiskHQ/lisk-hub into 1443-re…
massao Dec 10, 2018
824044c
:back: Revert mapDispatchToProps that breaks tests
massao Dec 11, 2018
2e4d3a1
:recycle: Add istanbul ignore on file
massao Dec 11, 2018
75e67c2
:recycle: Remove unit test of settingHOC
massao Dec 6, 2018
9fe3275
:recycle: Remove unit test of accountHOC and skip coverage test on HOC
massao Dec 7, 2018
7e949e3
:recycle: Remove unit tests of authInputsHOC
massao Dec 7, 2018
283a793
:recycle: Remove unit test of confirmVotesHOC
massao Dec 7, 2018
2a30ee6
:recycle: Remove unit tests of converterHOC
massao Dec 7, 2018
6196b8d
:recycle: Remove unit test of headerHOC
massao Dec 7, 2018
d84d7d7
:recycle: Remove authenticateHOC unit test and update mapDispatchToProps
massao Dec 7, 2018
e0a16c2
:recycle: Update mapDispatchToProps of currencyGraph
massao Dec 7, 2018
4ee92fa
:recycle: Update mapDispatchToProps of Dashboard
massao Dec 7, 2018
eef464e
:recycle: Update mapDIspatchToProps to receive an object
massao Dec 7, 2018
d691f9a
:recycle: Remove unit tests of loginHOC
massao Dec 7, 2018
db2ef3b
:recycle: Remove unit test for LoadingBarHOC
massao Dec 7, 2018
347196c
:recycle: Remove unit test of SecondPassphrase: ConfirmationHOC
massao Dec 7, 2018
777209b
:recycle: Remove unit tests of RegisterDelegateHOC
massao Dec 7, 2018
7663071
:recycle: Remove unit test of SecondPassphraseHOC
massao Dec 7, 2018
e58db1d
:recycle: Remove unit test of confirmHOC
massao Dec 7, 2018
eb821d6
:recycle: Remove unit test of voteUrlProcessorHOC
massao Dec 7, 2018
9db7791
:recycle: Remove unit test of votingHOC
massao Dec 7, 2018
f5b561d
:recycle: Remove unit test of register and toaster HOC
massao Dec 10, 2018
f5e0f6c
:recycle: Update all mapDispatchToProps to object syntax
massao Dec 10, 2018
d30f854
:recycle: Remove unused code from setting.js
massao Dec 10, 2018
26bf923
:recycle: Separate accountTransactions and remove unit test of HOC
massao Dec 10, 2018
e6e7050
:back: Revert mapDispatchToProps that breaks tests
massao Dec 11, 2018
e05fcfc
:recycle: Add istanbul ignore on file
massao Dec 11, 2018
0ad66c6
Merge branch '1443-remove-unit-tests-of-HOC' of github.com:LiskHQ/lis…
massao Dec 11, 2018
ff7fc23
:recycle: Remove commented out code for Language switcher in settings
slaweet Dec 11, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions i18n/locales/en/common.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@
"Create your second passphrase": "Create your second passphrase",
"Currency": "Currency",
"Current version is up-to-date.": "Current version is up-to-date.",
"Currently we speaking english and german.": "Currently we speaking english and german.",
"Custom Node": "Custom Node",
"Cut": "Cut",
"Dashboard": "Dashboard",
Expand Down Expand Up @@ -164,7 +163,6 @@
"Keep track of any Lisk ID balance. Only you will see who you follow.": "Keep track of any Lisk ID balance. Only you will see who you follow.",
"LSK received": "LSK received",
"LSK/BTC": "LSK/BTC",
"Language": "Language",
"Later": "Later",
"Latest activity": "Latest activity",
"Learn about blockchain with our comprehensive knowledge base.": "Learn about blockchain with our comprehensive knowledge base.",
Expand Down
1 change: 1 addition & 0 deletions src/components/account/index.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* istanbul skip file */
import { connect } from 'react-redux';
import { translate } from 'react-i18next';
import Account from './account';
Expand Down
52 changes: 0 additions & 52 deletions src/components/account/index.test.js

This file was deleted.

29 changes: 29 additions & 0 deletions src/components/accountTransactions/accountTransactions.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import React from 'react';
import grid from 'flexboxgrid/dist/flexboxgrid.css';
import ExplorerTransactions from './../transactions/explorerTransactions';
import SendTo from '../sendTo';
import styles from './accountTransactions.css';

class AccountTransactions extends React.Component {
// eslint-disable-next-line class-methods-use-this
render() {
return <div className={`${grid.row} ${styles.wrapper}`}>
<div className={`${grid['col-md-4']} ${styles.sendTo}`}>
<SendTo
address={this.props.match.params.address}
t={this.props.t}
account={this.props.account}
delegate={this.props.delegate}
/>
</div>
<div className={`${grid['col-sm-12']} ${styles.transactions} ${grid['col-md-8']} ${styles.transactions}`}>
<ExplorerTransactions
history={this.props.history}
address={this.props.match.params.address}
delegate={this.props.delegate} />
</div>
</div>;
}
}

export default AccountTransactions;
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,5 @@ describe('AccountTransaction Component', () => {
it('renders AccountTransaction Component and loads account transactions', () => {
const renderedAccountTransactions = wrapper.find(AccountTransactions);
expect(renderedAccountTransactions).to.be.present();
/* eslint-disable no-unused-expressions */
expect(searchTransactionsSpy).to.have.been.calledOnce;
expect(searchAccountSpy).to.have.been.calledOnce;
/* eslint-enable no-unused-expressions */
});
});
29 changes: 2 additions & 27 deletions src/components/accountTransactions/index.js
Original file line number Diff line number Diff line change
@@ -1,32 +1,7 @@
import React from 'react';
/* istanbul ignore file */
import { connect } from 'react-redux';
import { translate } from 'react-i18next';
import grid from 'flexboxgrid/dist/flexboxgrid.css';
import ExplorerTransactions from './../transactions/explorerTransactions';
import SendTo from '../sendTo';
import styles from './accountTransactions.css';

class AccountTransactions extends React.Component {
// eslint-disable-next-line class-methods-use-this
render() {
return <div className={`${grid.row} ${styles.wrapper}`}>
<div className={`${grid['col-md-4']} ${styles.sendTo}`}>
<SendTo
address={this.props.match.params.address}
t={this.props.t}
account={this.props.account}
delegate={this.props.delegate}
/>
</div>
<div className={`${grid['col-sm-12']} ${styles.transactions} ${grid['col-md-8']} ${styles.transactions}`}>
<ExplorerTransactions
history={this.props.history}
address={this.props.match.params.address}
delegate={this.props.delegate} />
</div>
</div>;
}
}
import AccountTransactions from './accountTransactions';

const mapStateToProps = state => ({
publicKey: state.account.publicKey,
Expand Down
1 change: 1 addition & 0 deletions src/components/authInputs/index.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* istanbul skip file */
import { connect } from 'react-redux';
import { translate } from 'react-i18next';

Expand Down
33 changes: 0 additions & 33 deletions src/components/authInputs/index.test.js

This file was deleted.

7 changes: 4 additions & 3 deletions src/components/authenticate/index.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* istanbul ignore file */
import { connect } from 'react-redux';
import { translate } from 'react-i18next';
import { accountUpdated } from '../../actions/account';
Expand All @@ -11,9 +12,9 @@ const mapStateToProps = state => ({
account: state.account,
});

const mapDispatchToProps = dispatch => ({
accountUpdated: data => dispatch(accountUpdated(data)),
});
const mapDispatchToProps = {
accountUpdated,
};

export default connect(
mapStateToProps,
Expand Down
58 changes: 0 additions & 58 deletions src/components/authenticate/index.test.js

This file was deleted.

7 changes: 4 additions & 3 deletions src/components/confirmVotes/index.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* istanbul ignore file */
import { connect } from 'react-redux';
import { translate } from 'react-i18next';

Expand All @@ -10,8 +11,8 @@ const mapStateToProps = state => ({
account: state.account,
});

const mapDispatchToProps = dispatch => ({
votePlaced: data => dispatch(votePlaced(data)),
});
const mapDispatchToProps = {
votePlaced,
};

export default connect(mapStateToProps, mapDispatchToProps)(translate()(ConfirmVotes));
92 changes: 0 additions & 92 deletions src/components/confirmVotes/index.test.js

This file was deleted.

9 changes: 5 additions & 4 deletions src/components/converter/index.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* istanbul ignore file */
import { connect } from 'react-redux';

import { settingsUpdated } from '../../actions/settings';
Expand All @@ -16,10 +17,10 @@ const mapStateToProps = state => ({
},
});

const mapDispatchToProps = dispatch => ({
settingsUpdated: data => dispatch(settingsUpdated(data)),
getPriceTicker: () => dispatch(getPriceTicker()),
});
const mapDispatchToProps = {
settingsUpdated,
getPriceTicker,
};

export default connect(
mapStateToProps,
Expand Down
Loading