Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements required in Passphrase generator #663

Closed
reyraa opened this issue Apr 3, 2018 · 0 comments
Closed

Improvements required in Passphrase generator #663

reyraa opened this issue Apr 3, 2018 · 0 comments
Assignees

Comments

@reyraa
Copy link
Contributor

reyraa commented Apr 3, 2018

Expected behaviour

  • parseInt uses a radix value to parse the given value for decimal, hex or any other radix.
  • Improvements in documentations is required.
  • L35 is redundant.

Actual behaviour

  • The usage of parseInt is not correct in some cases.
  • We're generating string literal to parse the value in hex
  • Descriptions are not clear enough
  • noop code in L35 must be removed.

Steps to reproduce

Source code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant