Remove noop in seed initialization - Subtask #663 #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyraa
changed the title
webmaster128
pushed a commit
to webmaster128/lisk-nano
that referenced
this pull request
Apr 7, 2018
This is a direct port of LiskHQ/lisk-desktop#653
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
There is a line that does nothing. As the comment above states, seed is between 1.6 and 3.2 (excluded). Thus
seed >= 0.1is always true and seed is assigned to seed.How did I fix it?
Remove the line that does nothing
How to test it?
Review or check the resulting step value.
Review checklist