Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transactions list shows No Activity message instead of Loading #348

Closed
reyraa opened this issue Feb 13, 2018 · 0 comments
Closed

Transactions list shows No Activity message instead of Loading #348

reyraa opened this issue Feb 13, 2018 · 0 comments
Assignees
@ginacontrino

Comments

@reyraa
Copy link
Contributor

reyraa commented Feb 13, 2018

Expected behaviour

  • If the account transactions have been loaded and is empty array, we should show No Activity message.
  • If the account transactions is getting loaded we should show Loading Message.

Actual behaviour

We always show No Activity m message if the account transactions array is empty.

Steps to reproduce

See transactions/wallet page, if loading of transaction takes over ~50ms (long animation frame/slow network) you'll see the No Activity message but then the list gets filled up.
@slaweet slaweet added the bug label Feb 22, 2018
@ginacontrino ginacontrino self-assigned this Feb 22, 2018
@ginacontrino ginacontrino mentioned this issue Feb 28, 2018
Merged
ginacontrino pushed a commit that referenced this issue Mar 5, 2018
Merge pull request #497 from LiskHQ/348-transaction-loader
3115565 
Hide transaction list and empty message when loading - Closes #348
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ginacontrino ginacontrino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@reyraa @slaweet @ginacontrino