Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide transaction list and empty message when loading - Closes #348 #497

Merged
merged 3 commits into from
Mar 5, 2018

Conversation

ginacontrino
Copy link
Contributor

@ginacontrino ginacontrino commented Feb 28, 2018

What was the problem?

The loading of the transaction list was not smooth, sometimes the empty message was showing, when the transactions where still loading

How did I fix it?

There was nothing implemented yet in the transaction list, so I added an extra condition for the loader.
I also added an extra loading state for the initial transaction request. So now instead of an error message or old transactions, we will just see a white background.

How to test it?

Set your network to slow in the browser, compare my branch with 0.2.0 and load a transaction page. You will probably see the difference.

Review checklist

@slaweet slaweet changed the base branch from 0.2.0 to 0.3.0 March 2, 2018 12:59
@slaweet slaweet changed the base branch from 0.3.0 to 0.2.0 March 5, 2018 12:49
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Gina

@ginacontrino ginacontrino merged commit 3115565 into 0.2.0 Mar 5, 2018
@ginacontrino ginacontrino deleted the 348-transaction-loader branch March 5, 2018 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants