Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account visual sometimes turns black in safari #338

Closed
slaweet opened this issue Feb 13, 2018 · 2 comments
Closed

Account visual sometimes turns black in safari #338

slaweet opened this issue Feb 13, 2018 · 2 comments
Assignees
@faival

Comments

@slaweet
Copy link
Contributor

slaweet commented Feb 13, 2018 •
edited by ginacontrino
Loading

Expected behaviour

The account visual should stay the say even in Safari

Actual behaviour

Sometimes, the account visual turns into a black circle.

Steps to reproduce

I wasn't able to reproduce it at will.

Gina: happens to me, when i change account and then resize the window
@slaweet slaweet added the bug label Feb 13, 2018
@reyraa
Copy link
Contributor

reyraa commented Feb 14, 2018

Just noticed the we get this error:

Warning: Can only update a mounted or mounting component. This usually means you called setState, replaceState, or forceUpdate on an unmounted component. This is a no-op.
Please check the code for the AccountVisual component.

It might be the source of this issue.

@slaweet slaweet added the *easy label Feb 14, 2018
@slaweet slaweet assigned reyraa and slaweet and unassigned reyraa Feb 15, 2018
@slaweet slaweet added *medium and removed *easy labels Feb 22, 2018
@slaweet slaweet mentioned this issue Mar 2, 2018
Closed
@slaweet slaweet assigned faival and slaweet and unassigned slaweet Mar 12, 2018
@faival faival mentioned this issue Mar 19, 2018
Merged
@slaweet slaweet removed their assignment Mar 21, 2018
faival added a commit that referenced this issue Mar 22, 2018
@faival
Merge pull request #562 from LiskHQ/530-migrate-account-switcher-to-a…
f89ddae 
…-page

Migrate account switcher to a page - Closes #530, #338
@faival
Copy link
Contributor

faival commented Mar 22, 2018

solved by mergin PR #562

@faival faival closed this as completed Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@faival faival

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@reyraa @faival @slaweet