Migrate account switcher to a page - Closes #530, #338 #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faival
changed the title
faival
changed the title
slaweet
suggested changes
Mar 20, 2018
There was a problem hiding this comment.
It works well, there are just a few details mentioned below, and
- the whole element overflows a bit:
- on M breakpoint the close button is out of view
- This can be removed
https://github.com/LiskHQ/lisk-hub/blob/80afda8289b75cb70bf345d14d36117fde2bdd90/src/components/dialog/dialogs.js#L10-L29
| background: #013165; | ||
| overflow-y: auto; | ||
| z-index: var(--accounts-index); | ||
| position: absolute; | ||
| -webkit-font-smoothing: antialiased; |
There was a problem hiding this comment.
There was a problem hiding this comment.
not supported by autoprefixer, as is vendor specific, and new spec font-smooth, is not yet supported by all browsers.
twitter.com/autoprefixer/status/444429500789841921?lang=nl
caniuse.com/#feat=font-smooth
| @@ -39,7 +39,7 @@ | |||
| font-size: var(--menu-bar-font-size-m); | |||
| font-family: var(--heading-font); | |||
| background-color: var(--color-white); | |||
| z-index: 1; | |||
| z-index: var(--menubar-index); | |||
There was a problem hiding this comment.
Good call. We should have used variables for z-indexes from the beginning.
src/utils/routes.js
Outdated
| regex: /\/accounts(?:\/[^/]*)?$/, | ||
| path: `${routes.accounts.path}/`, | ||
| params: 'dialog', | ||
| name: 'accounts', |
There was a problem hiding this comment.
It should be possible to remove this whole file because the only left modal (proxyLogin) doesn't have it's own path.
faival
force-pushed
the
530-migrate-account-switcher-to-a-page
branch
from
a228c7d to
bd50d0a
Compare
faival
force-pushed
the
530-migrate-account-switcher-to-a-page
branch
from
bd50d0a to
aa83abd
Compare
... because the dialog it uses was removed. It will be re-enabled in #279.
slaweet
approved these changes
Mar 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Accounts view is currently displayed in a modal dialog, and should reside on a new page accessible by /accounts url
How did I fix it?
How to test it?
go to main/dashboard, click on accountVisual menu,
Review checklist