Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require src/store/middlewares to have 100% test line coverage #157

Closed
slaweet opened this issue Jan 4, 2018 · 0 comments
Closed

Require src/store/middlewares to have 100% test line coverage #157

slaweet opened this issue Jan 4, 2018 · 0 comments
Assignees

Comments

@slaweet
Copy link
Contributor

slaweet commented Jan 4, 2018

Expected behaviour

Middlewares and reducers are the core of our application, so they should have the best test coverage. It is usually quite easy to test them.
karma-coverage check should be set up to override test coverage to require 100% line coverage on src/store/**, so that when we are adding more middlewares and reducers, CI will not allow us to merge it without full test coverage.

Actual behaviour

Some parts are missing test coverage.

@reyraa reyraa self-assigned this Jan 4, 2018
@slaweet slaweet changed the title Require src/store to have 100% test line coverage Require src/store/middlewares to have 100% test line coverage Feb 22, 2018
@slaweet slaweet assigned michaeltomasik and unassigned reyraa Mar 1, 2018
faival added a commit that referenced this issue Mar 13, 2018
…overage

Revert removal of istambul ignore - Closes #157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants