Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert removal of istambul ignore - Closes #157 #546

Merged
merged 1 commit into from
Mar 13, 2018
Merged

Revert removal of istambul ignore - Closes #157 #546

merged 1 commit into from
Mar 13, 2018

Conversation

faival
Copy link
Contributor

@faival faival commented Mar 13, 2018

What was the problem?

Build is broken in 0.3.0 due to some missing coverage.

How did I fix it?

Add ignore istambul statement to fix build, till we cover that test

How to test it?

Jenkins build should

Review checklist

@faival faival requested a review from michaeltomasik March 13, 2018 09:14
@faival faival self-assigned this Mar 13, 2018
@faival faival changed the title Revert removal of istambul ignore Revert removal of istambul ignore - Closes #157 Mar 13, 2018
slaweet
slaweet approved these changes Mar 13, 2018
View reviewed changes
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@faival faival merged commit 3b37e81 into 0.3.0 Mar 13, 2018
@faival faival deleted the 157-add-istambul-ignore-failing-coverage branch March 13, 2018 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaweet slaweet slaweet approved these changes

@michaeltomasik michaeltomasik Awaiting requested review from michaeltomasik

Assignees

@faival faival

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faival @slaweet