Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky new account e2e test #135

Closed
slaweet opened this issue Dec 21, 2017 · 0 comments
Closed

Fix flaky new account e2e test #135

slaweet opened this issue Dec 21, 2017 · 0 comments
Assignees
@slaweet

Comments

@slaweet
Copy link
Contributor

slaweet commented Dec 21, 2017

Expected behaviour

New account e2e test should be stable

Actual behaviour

New account e2e test is flaky. Most likely because it uses the same class (.next-button) for multiple buttons in different steps.
@slaweet slaweet self-assigned this Dec 21, 2017
slaweet added a commit that referenced this issue Dec 21, 2017
@slaweet
Fix flaky new account e2e test - Closes #135
55ac3ec 
the problem was that the same class name (.next-button) was used for multiple buttons
in different steps and e2e tests were getting the button from the
previous step, because it was still in the DOM because of hide animation
@slaweet slaweet mentioned this issue Dec 21, 2017
Merged
slaweet added a commit that referenced this issue Dec 21, 2017
@slaweet
Merge pull request #139 from LiskHQ/135-flaky-new-account-e2e
9ddb699 
Fix flaky new account e2e test - Closes #135
@Matthelonianxl Matthelonianxl mentioned this issue Jun 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slaweet slaweet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@slaweet