Fix flaky new account e2e test - Closes #135 #139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
the problem was that the same class name (.next-button) was used for multiple buttons
in different steps and e2e tests were getting the button from the
previous step, because it was still in the DOM because of hiding animation
How did I fix it?
Used different class names
How to test it?
Run e2e tests multiple times, namely:
npm run e2e-test -s -- --specs test/e2e/registerSecondPassphrase.feature:2
npm run e2e-test -s -- --specs test/e2e/login.feature:28
Review checklist