Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky new account e2e test - Closes #135 #139

Merged
merged 1 commit into from
Dec 21, 2017

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented Dec 21, 2017

What was the problem?

the problem was that the same class name (.next-button) was used for multiple buttons
in different steps and e2e tests were getting the button from the
previous step, because it was still in the DOM because of hiding animation

How did I fix it?

Used different class names

How to test it?

Run e2e tests multiple times, namely:
npm run e2e-test -s -- --specs test/e2e/registerSecondPassphrase.feature:2
npm run e2e-test -s -- --specs test/e2e/login.feature:28

Review checklist

@slaweet slaweet self-assigned this Dec 21, 2017
@slaweet slaweet requested a review from ginacontrino December 21, 2017 13:53
the problem was that the same class name (.next-button) was used for multiple buttons
in different steps and e2e tests were getting the button from the
previous step, because it was still in the DOM because of hide animation
@slaweet slaweet force-pushed the 135-flaky-new-account-e2e branch from 55ac3ec to dc78e69 Compare December 21, 2017 16:58
Copy link
Contributor

@ginacontrino ginacontrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@slaweet slaweet merged commit 9ddb699 into rebranding Dec 21, 2017
@slaweet slaweet deleted the 135-flaky-new-account-e2e branch December 21, 2017 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants