Refactor api calls in middlewares - Closes #770 #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginacontrino
force-pushed
the
770-middleware-api-requests-refactor
branch
from
a619991 to
ea6dca2
Compare
ginacontrino
force-pushed
the
770-middleware-api-requests-refactor
branch
2 times, most recently
from
8624d97 to
c74672e
Compare
ginacontrino
force-pushed
the
770-middleware-api-requests-refactor
branch
from
c74672e to
9b0f375
Compare
ginacontrino
force-pushed
the
770-middleware-api-requests-refactor
branch
from
01e741f to
41319a9
Compare
reyraa
approved these changes
Jun 18, 2018
This was referenced Jun 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
There were api calls in the account middleware and some transaction actions and api calls in the account actions that didnt belong in there
How did I fix it?
Moved transaction related api calls to
src/utils/api/transactions.jsand actions tosrc/actions/transactions.jsAnd transformed further direct api calls in the account middleware into actions in
src/actions/account.jsAdjusted all tests
How to test it?
Everything should work exactly like before - be careful testing the tests as well
Review checklist