Show/Hide network options depending on url params - Closes #47 #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginacontrino
force-pushed
the
47-changing-network-options
branch
from
82c98a2 to
2c5d2f3
Compare
ginacontrino
force-pushed
the
47-changing-network-options
branch
from
bdfabd0 to
a4c0d6c
Compare
slaweet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
The network options shouldnt show by default
How did I fix it?
By using the parameter ?showNetwork=true the network options are visible again
How to test it?
http://localhost:8080/#/?showNetwork=true
-> set some node and make sure it works
http://localhost:8080/#/?showNetwork=false
-> log in and make sure you are logged in with mainnet
Review checklist