Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random index calculation in resetForm() - Closes #651 #652

Merged
merged 1 commit into from
Apr 4, 2018

Conversation

webmaster128
Copy link
Contributor

What was the problem?

random index did not return random index. See #651.

How did I fix it?

Apply correct formula, see #651

How to test it?

Hmm, I din't know how to build this project. But I guess account creation should now include the last word in the password confirmation step.

Review checklist

@webmaster128
Copy link
Contributor Author

CI is failing with "TimeoutError: waiting for element '.joyride-tooltip__header'". I have no clue what that means. Can this be related to my change?

@slaweet slaweet requested a review from reyraa April 3, 2018 06:42
@reyraa
Copy link
Contributor

reyraa commented Apr 3, 2018

I'm so glad to see you dove so deep into code to find this issue. My presumption - mistakenly - was that 1 is inclusive in the returned value of Math.random. Thanks for the descriptive ticket and clean PR.

@reyraa reyraa changed the base branch from development to 0.4.0 April 3, 2018 10:13
@webmaster128
Copy link
Contributor Author

My pleasure :) All 3 passphrase related PRs can be ported to Lisk Nano. What is the strategy here? Are those changes needed in nano? Do you want me to port them? Or do you do that on your own?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants