Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saved Accounts improvements on xs breakpoint - Closes #590 #645

Merged
merged 3 commits into from
Apr 5, 2018
Merged

Saved Accounts improvements on xs breakpoint - Closes #590 #645

merged 3 commits into from
Apr 5, 2018

Conversation

faival
Copy link
Contributor

@faival faival commented Mar 29, 2018 •
edited
Loading

What was the problem?

Some layout problems in xs devices

How did I fix it?

  • decrease size of cards
  • adapt bottom of edit button to account for ios Appbar
  • move remove button to top of card
  • decrease size of close button

How to test it?

screen shot 2018-04-05 at 15 04 48
screen shot 2018-04-05 at 15 05 13
screen shot 2018-04-05 at 15 05 25
screen shot 2018-04-05 at 15 05 39

Review checklist

@faival faival self-assigned this Mar 29, 2018
@faival faival force-pushed the 590-saved-accounts-improvements-on-xs-cherrypick branch from ff4b083 to 88fdd0f Compare March 29, 2018 12:56
@faival faival requested a review from reyraa March 29, 2018 13:11
slaweet
slaweet reviewed Apr 4, 2018
View reviewed changes
Copy link
Contributor

@slaweet slaweet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest the following changes:

  • move "You Lisk IDs" up to align with "close" button
  • move the avatar to the left to make it centered
  • move "Testnet" up to avoid collision with the avatar
  • move amount and address up to have space for moving the "Remove" button at the bottom of the card.
  • horizontally center "plus" image in "Add a Lisk ID" card, and maybe move the triangle and the circle more to the sides.

@faival faival force-pushed the 590-saved-accounts-improvements-on-xs-cherrypick branch from 88fdd0f to 0a9626e Compare April 5, 2018 13:10
@faival
Copy link
Contributor Author

faival commented Apr 5, 2018

@slaweet @reyraa suggestions applied.

@reyraa reyraa merged commit a7540e5 into 0.4.0 Apr 5, 2018
@reyraa reyraa deleted the 590-saved-accounts-improvements-on-xs-cherrypick branch April 5, 2018 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaweet slaweet slaweet left review comments

@reyraa reyraa reyraa approved these changes

Assignees

@faival faival

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faival @reyraa @slaweet