Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saved Accounts improvements on xs breakpoint - Closes #590 #622

Closed
wants to merge 1 commit into from
Closed

Saved Accounts improvements on xs breakpoint - Closes #590 #622

wants to merge 1 commit into from

Conversation

faival
Copy link
Contributor

@faival faival commented Mar 27, 2018 •
edited
Loading

What was the problem?

Some layout problems in xs devices

How did I fix it?

  • decrease size of cards
  • adapt bottom of edit button to account for ios Appbar
  • move remove button to top of card
  • decrease size of close button

How to test it?

accounts-xs
accounts-xs-edit

Review checklist

@faival faival self-assigned this Mar 27, 2018
@faival faival closed this Mar 28, 2018
@faival faival force-pushed the 590-saved-accounts-improvements-on-xs-breakpoint branch from 0daf3a6 to 3e852b2 Compare March 28, 2018 15:53
@faival faival reopened this Mar 28, 2018
@faival faival closed this Mar 29, 2018
@faival faival force-pushed the 590-saved-accounts-improvements-on-xs-breakpoint branch from 55ed497 to 7e70187 Compare March 29, 2018 07:21
@faival faival reopened this Mar 29, 2018
@faival faival closed this Mar 29, 2018
@faival faival deleted the 590-saved-accounts-improvements-on-xs-breakpoint branch March 29, 2018 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: invalid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faival @karmacoma @slaweet