Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove back to list.io link #619

Closed
wants to merge 2 commits into from

Conversation

itssujan
Copy link
Contributor

What was the problem?

Removing the "back to lisk.io" from login page

How did I fix it?

Removed the HTML code which is used to display the content

How to test it?

Visit the login page and ensure there's no 'back to list.io' link

Review checklist

Screenshot

screen shot 2018-03-26 at 1 55 55 pm

@slaweet slaweet changed the base branch from development to 0.4.0 March 27, 2018 07:40
faival
faival previously requested changes Mar 27, 2018
@@ -144,12 +144,6 @@ class Login extends React.Component {
<Box className={styles.wrapper}>
<section className={`${styles.login} ${styles[this.state.passInputState]}`}>
<section className={styles.table}>
<header>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @itssujan thanks for this!

I think we can safely remove the related styles for .backButton, .icon, .label in logo.css

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Got that in @faival

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool @itssujan, just one more thing:
As we have removed completely the markup for it, we should remove all styles belonging to it, this applies to references to the markup along multiple breakpoints, e.g. https://github.com/itssujan/lisk-hub/blob/2b128e92e8cfeec565d049913ab2b11dff662074/src/components/login/login.css#L342,

also once this is done, probably we can also remove the var definitions at the top
https://github.com/itssujan/lisk-hub/blob/2b128e92e8cfeec565d049913ab2b11dff662074/src/components/login/login.css#L16

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itssujan we got updates related to this issue.
we'll update #599, to reflect the changes, please have a look, just for pure workflow will dismiss the review, so feel free to reopen when updated.
we apologise for the late notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants