-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove back to list.io link #619
Conversation
@@ -144,12 +144,6 @@ class Login extends React.Component { | |||
<Box className={styles.wrapper}> | |||
<section className={`${styles.login} ${styles[this.state.passInputState]}`}> | |||
<section className={styles.table}> | |||
<header> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @itssujan thanks for this!
I think we can safely remove the related styles for .backButton, .icon, .label
in logo.css
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Got that in @faival
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool @itssujan, just one more thing:
As we have removed completely the markup for it, we should remove all styles belonging to it, this applies to references to the markup along multiple breakpoints, e.g. https://github.com/itssujan/lisk-hub/blob/2b128e92e8cfeec565d049913ab2b11dff662074/src/components/login/login.css#L342,
also once this is done, probably we can also remove the var definitions at the top
https://github.com/itssujan/lisk-hub/blob/2b128e92e8cfeec565d049913ab2b11dff662074/src/components/login/login.css#L16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the problem?
Removing the "back to lisk.io" from login page
How did I fix it?
Removed the HTML code which is used to display the content
How to test it?
Visit the login page and ensure there's no 'back to list.io' link
Review checklist
Screenshot