Implement onboarding - Closes #63 #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginacontrino
force-pushed
the
63-onboarding
branch
5 times, most recently
from
18db6ff to
9ab72eb
Compare
ginacontrino
force-pushed
the
63-onboarding
branch
7 times, most recently
from
a55540e to
5e7d262
Compare
slaweet
reviewed
Mar 23, 2018
src/components/setting/setting.js
Outdated
| @@ -83,6 +88,17 @@ class Setting extends React.Component { | |||
| <p>{t('Lock ID’s automatically after 10 minutes.')}</p> | |||
| </article> | |||
| </div> | |||
| <div> | |||
There was a problem hiding this comment.
this also needs this.showOnboardingSetting() condition, because of swiping
slaweet
reviewed
Mar 23, 2018
src/components/onboarding/steps.js
Outdated
| }, | ||
| { | ||
| title: t('Timeout'), | ||
| text: t('After 10 minutes of inactivity you will be logged out to prevent an unauthorized access to your Lisk ID. This will reset as soon as you become active again. You can also reset the timer anytime by clicking on the countdown.'), |
There was a problem hiding this comment.
After 10 minutes of not using your passphrase, your Lisk ID will be locked to prevent an unauthorized use of your Lisk ID. The timer resets when you send any transaction. You can also reset the timer by clicking "reset" when there are less than 5 minutes left.
src/components/onboarding/steps.js
Outdated
| }, | ||
| { | ||
| title: t('Lisk ID'), | ||
| text: t('Click here to view your balance, Lisk ID and saved Lisk IDs.'), |
There was a problem hiding this comment.
Here you see you address and balance. You can click your account avatar to see all your saved IDs.
src/components/onboarding/steps.js
Outdated
| }, | ||
| { | ||
| title: t('Keep the overview'), | ||
| text: t('Click here to go back to the main page of Lisk Hub and find all relevant statistics and ID information'), |
There was a problem hiding this comment.
Click here to go to the main page of Lisk Hub and find all relevant statistics and ID information.
src/components/onboarding/index.js
Outdated
| run={this.props.isAuthenticated && isDesktop && (start || !this.isAlreadyOnboarded)} | ||
| locale={{ | ||
| last: (<span>{this.props.t('Complete')}</span>), | ||
| skip: skip ? <span>{this.props.t('Use Lisk App')}</span> : <span>{this.props.t('Click here to skip')}</span>, |
src/components/setting/setting.js
Outdated
| }>{t('Start')}</button> | ||
| <article> | ||
| <h5>{t('Start the onboarding')}</h5> | ||
| <p>{t('Take a quick tour to see how the Lisk App works.')}</p> |
ginacontrino
force-pushed
the
63-onboarding
branch
3 times, most recently
from
2c4026d to
e1c4392
Compare
added 7 commits
March 27, 2018 16:42
added 17 commits
March 27, 2018 16:42
ginacontrino
force-pushed
the
63-onboarding
branch
from
e1c4392 to
4c6d29a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
We had no onboarding
How did I fix it?
By using the package
react-joyridehttps://github.com/gilbarbara/react-joyride
How to test it?
This is WIP
Todo:
Tests will be done in #589
Mobile will be implemented in #588
What does it look like?
Review checklist